Move Journal Details section above Contacts section #519
Conversation
There was a problem hiding this comment.
Hey @frozenhelium, the order of the PDF looks good.
When a user downloads a document that doesn't have journal details information, the label is still listed in the PDF, and has four No content available. placeholders.
If content is added, the correct single field Significance Discussion is displayed.
If other Journal Details are added but not Significance Discussion, that is also displayed correctly.
Could you fix the first scenario? Ideal, the entire section would not appear, but having only one No content available. placeholder is also a good option.
|
@wrynearson I'll look into it |
|
@wrynearson It should be fixed now |
There was a problem hiding this comment.
Hi @frozenhelium, there's still the issue of four "No content available." placeholders when a user selects that the ATBD will or has been published, but they don't have any content in the four field.
When a user has content in one of the four, there are then three "No content available." placeholders.
I tested this with the /pdf-preview, and it occurs there.
Ideally:
- If the document has content in the
Significance Discussiontext box, it should be displayed in the PDF - If the document does not have content in the
Significance Discussion, there should be no rendering of theSignificance Discussionor any of the other fields in theJournal Detailsin the PDF. - Regardless of whether or not there's content in the
Significance Discussiontext box, the other three sub-sections in theJournal Detailsshould not appear in the PDF.
frozenhelium
force-pushed
the
fix/atbd-view-order
branch
from
3c017e4
to
c6ad83d
Compare
|
Oops, forgot to merge this... doing it now @frozenhelium |
Upstream: NASA-IMPACT/nasa-apt#682 (comment)